[Webkit-unassigned] [Bug 97995] Remove unused sys/mman.h include

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 14:27:57 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=97995





--- Comment #5 from Darin Adler <darin at apple.com>  2012-10-01 14:28:21 PST ---
(From update of attachment 166415)
View in context: https://bugs.webkit.org/attachment.cgi?id=166415&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        The sys/mman.h is not used and removing it improves portability as not
> +        all systems have sys/mman.h.

Where did you get the information <sys/mman.h> is not used? On OS X the madvise function and MADV_FREE constant that are used in this file is from that header. The correct change would be to put this include inside #if OS(DARWIN).

Unless there is some other reason that we don’t need the include on OS X that I am not aware of.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list