[Webkit-unassigned] [Bug 96627] [EFL] Use the shareable GraphicsContext3DOpenGL* implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96627





--- Comment #16 from Yael <yael.aharon.m at gmail.com>  2012-10-01 06:43:30 PST ---
(In reply to comment #15)
> (From update of attachment 166164 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166164&action=review
> 
> >> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:43
> >> +    if (renderStyle == GraphicsContext3D::RenderToCurrentGLContext)
> > 
> > There seems to be an inconsistency here. GraphicsContext3D::createForCurrentGLContext() sets renderStyle to GraphicsContext3D::RenderToCurrentGLContext.
> > So we always return here without creating a GL context.
> 
> That seems generally correct, doesn't it? There's no surface, etc. to create in that case, no?

The context that we are supposed to create here is used as key for the hash table. Not creating one, as proposed by this patch, triggers ASSERT in debug builds.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.