[Webkit-unassigned] [Bug 95188] [GTK] Save original uri for downloaded files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95188





--- Comment #5 from Claudio Saavedra <csaavedra at igalia.com>  2012-10-01 05:45:42 PST ---
(From update of attachment 166431)
View in context: https://bugs.webkit.org/attachment.cgi?id=166431&action=review

>> Source/WebKit/gtk/webkit/webkitdownload.cpp:473
>> +        g_object_unref(file);
> 
> Use GRefPtr and you don't need this.

Fixed in a separate bug, already pushed.

>> Source/WebKit/gtk/webkit/webkitdownload.cpp:478
>> +        (gpointer)webkit_network_request_get_uri(priv->networkRequest), G_FILE_QUERY_INFO_NONE, NULL, &error);
> 
> Why not using g_file_set_attribute_string()? so that you don't need the gpointer cast nor the attribute type parameter. Use 0 instead of NULL. We typically don't use that indentation, new line should be under the ( even if the style checker complains, I think it's a bug in the style checker script.

OK, thanks.

>> Source/WebKit/gtk/webkit/webkitdownload.cpp:482
>> +        g_error_free(error);
> 
> We could use a GOwnPtr for the error too. I'm not sure showing a warning here is useful, maybe we can just silently ignore the error, since it doesn't affect the download at all.

You're right, I'll remove the warning.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.