[Webkit-unassigned] [Bug 96627] [EFL] Use the shareable GraphicsContext3DOpenGL* implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96627





--- Comment #15 from Simon Hausmann <hausmann at webkit.org>  2012-10-01 04:02:22 PST ---
(From update of attachment 166164)
View in context: https://bugs.webkit.org/attachment.cgi?id=166164&action=review

>> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:47
>> +    , m_compiler(isGLES2Compliant() ? SH_ESSL_OUTPUT : SH_GLSL_OUTPUT)
> 
> This will crash.
> GraphicsContext3D::isGLES2Compliant() is calling on m_private which was not created yet.
> You need to change GraphicsContext3D::isGLES2Compliant() to simply return a value, like other ports do.

Yael is right, and there's no reason for isGLES2Compliant() to use m_private, since it's just returning true or false depending on #ifdef, so that's easy to fix :)

>> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:43
>> +    if (renderStyle == GraphicsContext3D::RenderToCurrentGLContext)
> 
> There seems to be an inconsistency here. GraphicsContext3D::createForCurrentGLContext() sets renderStyle to GraphicsContext3D::RenderToCurrentGLContext.
> So we always return here without creating a GL context.

That seems generally correct, doesn't it? There's no surface, etc. to create in that case, no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.