[Webkit-unassigned] [Bug 91912] Adding "all" to -webkit-user-select

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91912





--- Comment #92 from Ryosuke Niwa <rniwa at webkit.org>  2012-10-31 23:43:04 PST ---
> > >>> Source/WebCore/page/EventHandler.cpp:859
> > >>> +        newSelection.setExtent(positionAfterNode(rootUserSelectAllForMousePressNode).downstream(CanCrossEditingBoundary));
> > >> 
> > >> Ditto about re-using adjustForwardPositionForUserSelectAll. Maybe adjustForwardPositionForUserSelectAll should take root user select node as an argument?
> > > 
> > > No, the other functions take into account the text direction that we don't need to take into account here.
> > > I don't believe there is any need to change this.
> > 
> > If we merged the two functions and just had adjustToPositionAfterNode as the argument, we can call it twice here as in:
> > newSelection.setBase(adjustPositionForUserSelectAll(rootUserSelectAllForMousePressNode, AdjustToPositionBeforeNode));
> > newSelection.setExtent(adjustPositionForUserSelectAll(rootUserSelectAllForMousePressNode, AdjustToPositionAfterNode));
> I will do that to stop all this. I don't believe this is necessary, but we have spent way too much time on this patch already.

Hehe, sorry about the bikeshedding. You can leave as is if you want. I just thought it's nice to encapsulate positionAfter/BeforeNode(~).downstream/upstream(~) inside some function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.