[Webkit-unassigned] [Bug 99588] Use the new forwarder2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99588





--- Comment #16 from Peter Beverloo <peter at chromium.org>  2012-10-31 09:32:44 PST ---
(From update of attachment 171471)
View in context: https://bugs.webkit.org/attachment.cgi?id=171471&action=review

Thanks for the updated patch, Felipe! Be sure to reply to Tony's remarks in comment 14 as well.

> Tools/ChangeLog:6
> +        "Reviewed by NOBODY (OOPS!)."

nit: no need for the quotes here :).

> Tools/ChangeLog:8
> +        It’s currently not possible to run the Clank test suite on

Clank?

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:88
> +FORWARDER_TIMEOUT_SECS = 30

nit: Should we place this line after line 84 for additional clarity?

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:451
> +    _TIMEOUT = 3

nit: Other constants don't have the underscore prefix, I'd prefer if we could stay consistent here.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:455
> +        self._port = android_port

self._port is not used elsewhere in this class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.