[Webkit-unassigned] [Bug 100851] [V8] use toV8Fast in all relevant getters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100851


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #171640|review?                     |review-
               Flag|                            |




--- Comment #2 from Kentaro Hara <haraken at chromium.org>  2012-10-31 07:13:46 PST ---
(From update of attachment 171640)
View in context: https://bugs.webkit.org/attachment.cgi?id=171640&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:297
> +    die("IsDOMNodeType is out of date with respect to $interfaceName") if IsDOMNodeType($interfaceName) != IsNodeSubType($dataNode);

Why are both IsDOMNodeType() and IsNodeSubType() needed, given that they should return the same result?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1121
> +    } elsif (IsDOMNodeType($attrType) && IsDOMNodeType($interfaceName)) {
> +        AddToImplIncludes($attrType.".h");
>          push(@implContentDecls, "    return toV8Fast($result, info, imp);\n");

Some Node-type classes have custom implementation of toV8() in bindings/v8/custom/*. Wouldn't it cause a problem? I mean, if you call toV8Fast() here, you might end up failing to call custom toV8().

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:-4031
> -    return 1 if $type eq 'HTMLElement';
> -    return 1 if $type eq 'HTMLUnknownElement';
> -    return 1 if $type eq 'HTMLFormElement';
> -    return 1 if $type eq 'HTMLTableCaptionElement';
> -    return 1 if $type eq 'HTMLTableSectionElement';

Isn't IsDOMNodeType() used by other places? I want to make sure that this change won't affect other places.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.