[Webkit-unassigned] [Bug 96597] Float block's logical top margin is illegal in vertical writing mode.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96597


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164050|review?                     |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Hajime Morrita <morrita at google.com>  2012-10-30 03:35:35 PST ---
(From update of attachment 164050)
View in context: https://bugs.webkit.org/attachment.cgi?id=164050&action=review

Looks good. Please adress my nitpicky comment.

> Source/WebCore/ChangeLog:8
> +        Float block's logical top margin is illegal in vertical writing mode.

Please don't repeat this.

> LayoutTests/ChangeLog:9
> +        This test's block should be at the center of black border

This explanation should be in the test so that test is more readable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.