[Webkit-unassigned] [Bug 100235] [V8] Remove ScriptController::windowShell()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100235





--- Comment #10 from Dan Carney <dcarney at google.com>  2012-10-29 09:14:08 PST ---
(In reply to comment #7)
> (From update of attachment 170898 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170898&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3421
> > +        if (frame->script()->initializeMainWorld()) {
> 
> There's no "IfNeeded" here?
> 
> > Source/WebCore/bindings/v8/ScriptController.cpp:328

This is a new method. It returns true if the world wasn't initialized and initialization was successful. The semantics are slightly different that the method on V8DOMWindowShell, so I wasn't sure what to call it. It is exactly equivalent to:

windowShell.context().IsEmpty() && windowShell. initializeIfNeeded()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.