[Webkit-unassigned] [Bug 100598] [EFL][AC] Fix bugs preventing us from running layout tests with AC turned on

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100598





--- Comment #14 from Dominik Röttsches (drott) <dominik.rottsches at intel.com>  2012-10-29 07:22:05 PST ---
(In reply to comment #13)
> (In reply to comment #11)
> > (In reply to comment #4)
> > > (From update of attachment 171211 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=171211&action=review
> > > 
> > > > Tools/EWebLauncher/main.c:810
> > > > +#ifdef WTF_USE_ACCELERATED_COMPOSITING && defined HAVE_ECORE_X
> > > 
> > > I feel this is more readable:
> > > #if defined(WTF_USE_ACCELERATED_COMPOSITING) && defined(HAVE_ECORE_X)
> > 
> > While we're at it, and I don't mean to halt the cq+, but shouldn't the first part be 
> > #if USE(ACCELERATED_COMPOSITING)?
> 
> AFAIK USE() macro is defined only internally to webkit.
> EWebLauncher is not part of webkit itself and so the USE() macro is not defined.

Alright, thanks for checking. Sorry for the noise then.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.