[Webkit-unassigned] [Bug 100061] [chromium] Device scale factor should be no-op when applyPageScaleFactorInCompositor == 0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100061





--- Comment #10 from Adam Barth <abarth at webkit.org>  2012-10-26 15:48:57 PST ---
(From update of attachment 170770)
View in context: https://bugs.webkit.org/attachment.cgi?id=170770&action=review

Why do we need to teach WebCore about this setting if it is only ever used in the WebKit layer?  It seems instead that we should teach PageWidgetDelegate.cpp how to find the WebSettings.

> Source/WebCore/page/Settings.h:644
> +        void setApplyDefaultDeviceScaleFactorInCompositor(bool enabled) { m_applyDefaultDeviceScaleFactorInCompositor = enabled; }
> +        bool applyDefaultDeviceScaleFactorInCompositor() const { return m_applyDefaultDeviceScaleFactorInCompositor; }

There is no such thing as a "default" device scale factor.  There is only a "device scale factor" and a "page scale factor".  There used to be a "default" device scale factor, but we deleted that notion.  Can you rename this setting?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.