[Webkit-unassigned] [Bug 82315] [Texmap][EFL] Implementation of AC related functions in ChromeClientEfl and ewkView.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82315





--- Comment #20 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-10-26 01:48:38 PST ---
(From update of attachment 170846)
View in context: https://bugs.webkit.org/attachment.cgi?id=170846&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:255
> +    bool compositingActive;

isCompositingActive

> Source/WebKit/efl/ewk/ewk_view.cpp:960
> +    if (priv->compositingObject)
> +        evas_object_del(priv->compositingObject);

use RefPtr they support evas objects

> Source/WebKit/efl/ewk/ewk_view.cpp:4572
> +void ewk_view_root_graphics_layer_set(Evas_Object* ewkView, WebCore::GraphicsLayer* rootLayer)

Why cant these be in the EwkViewImpl ?

> Source/WebKit/efl/ewk/ewk_view.cpp:4577
> +    bool active = rootLayer ? true : false;

= !!rootLayer

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.