[Webkit-unassigned] [Bug 100066] [EFL][WK2] Add APIs to get/set the encoding detector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100066





--- Comment #4 from Jinwoo Song <jinwoo7.song at samsung.com>  2012-10-25 17:33:19 PST ---
(From update of attachment 170062)
View in context: https://bugs.webkit.org/attachment.cgi?id=170062&action=review

>> Source/WebKit2/UIProcess/API/C/WKPreferences.h:223
>> +// Defaults to false.
> 
> IMHO, it depends on policy. So I would like to remove this comment.

There are default values for each setting member variables in Setting.cpp. I think its common to comment it.

>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:165
>>> +    ASSERT_FALSE(ewk_setting_uses_encoding_detector_get(settings));
>> 
>> It would be better to add comments that the default setting value is 'false' to explain why ASSERT_FALSE() is used.
> 
> IMHO, it depends on policy. So I would like to remove this line of test.

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.