[Webkit-unassigned] [Bug 100288] [EFL][WK2][AC] Regression(132392) infinite loop when displaying certain animations.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 25 11:41:06 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=100288





--- Comment #15 from Yael <yael.aharon.m at gmail.com>  2012-10-25 11:42:13 PST ---
(In reply to comment #14)
> (From update of attachment 170643 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170643&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:238
> > +    WTF::Vector <WebCore::IntRect> m_dirtyRects;
> 
> Just a thought but why store the dirty rects in a Vector if we are going to construct a Region from them anyway?
> We could have a "Region m_dirtyRegion;" member instead and we would call Region::unite() in redrawRegion(). This would avoid the iteration over m_dirtyRects in the timer callback.

The issue is that we are adding more rects while we are painting. We have to separate the already existing rects from the newly added, or we will end up with the same infinite loop I was trying to solve.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list