[Webkit-unassigned] [Bug 100288] [EFL][WK2][AC] Regression(132392) infinite loop when displaying certain animations.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100288





--- Comment #7 from Yael <yael.aharon.m at gmail.com>  2012-10-25 07:00:56 PST ---
(In reply to comment #6)
> (From update of attachment 170628 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170628&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:265
> > +    while (m_dirtyRects.size()) {
> > +        dirtyRegion.unite(m_dirtyRects.first());
> > +        m_dirtyRects.remove(0);
> > +    }
> 
> con't you not just do m_dirtyRects.clear() or so afterward? Is remove really safe here?
> 
Since I always take the first item, I think remove is safe here.

> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:268
> > +    Vector<IntRect> rects = dirtyRegion.rects();
> > +    Vector<IntRect>::iterator end = rects.end();
> 
> how are regions united? do you really get multiple regions afterward?
> 
I get multiple rects before drawing, not regions. Using the region removes the need for redundant drawing.

> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:285
> > +{
> > +    if (!m_displayTimer.isActive())
> > +        m_displayTimer.startOneShot(0);
> > +    m_dirtyRects.append(rect);
> 
> does this actually happen?
yes, with the test page listed in comment #0 .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.