[Webkit-unassigned] [Bug 98215] webkit-patch optimize-baselines thinks it's succeeding, but it's not

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98215





--- Comment #6 from Dirk Pranke <dpranke at chromium.org>  2012-10-24 13:50:16 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > This is still a real bug. The chromium -expected.txt results should be merged into platform/chromium.
> 
> Oh, sorry, I missed that. I'll take a look at that, too.

Okay, running webkit-patch optimize-baselines -v fast/canvas/canvas-render-layer.html (with slightly tweaked logging) now, I get:

Optimizing fast/canvas/canvas-render-layer.html.
No optimization found for canvas-render-layer-expected.png, optimal?
  Tools/Scripts/webkitpy/LayoutTests/platform/chromium-win: f9f3e2
  Tools/Scripts/webkitpy/LayoutTests/platform/mac: 07349f
  Tools/Scripts/webkitpy/LayoutTests/platform/efl: 148b27
  Tools/Scripts/webkitpy/LayoutTests/platform/qt: 79670b
  Tools/Scripts/webkitpy/LayoutTests/platform/gtk: a33e86
  Tools/Scripts/webkitpy/LayoutTests/platform/chromium-mac: b426b7
No baselines found for canvas-render-layer-expected.wav
Optimizing canvas-render-layer-expected.txt
before: 
  Tools/Scripts/webkitpy/LayoutTests/platform/chromium-win: 0b0691
  Tools/Scripts/webkitpy/LayoutTests/platform/mac: 439e3b
  Tools/Scripts/webkitpy/LayoutTests/platform/efl: 0b0691
  Tools/Scripts/webkitpy/LayoutTests/platform/qt: 0b0691
  Tools/Scripts/webkitpy/LayoutTests/platform/chromium-win-xp: 0b0691
  Tools/Scripts/webkitpy/LayoutTests/platform/gtk: 0b0691
  Tools/Scripts/webkitpy/LayoutTests/platform/win: 0b0691
  Tools/Scripts/webkitpy/LayoutTests/platform/chromium-mac-snowleopard: 0b0691
  Tools/Scripts/webkitpy/LayoutTests/platform/chromium-linux: 0b0691
  Tools/Scripts/webkitpy/LayoutTests/platform/chromium-mac: 0b0691
after: 
  Tools/Scripts/webkitpy/LayoutTests/platform/win-7sp0: 0b0691
  Tools/Scripts/webkitpy/LayoutTests/platform/mac: 439e3b
  Tools/Scripts/webkitpy/LayoutTests: 0b0691

So perhaps now that chromium-mac doesn't fall back to mac, things are working okay (in Ojan's case, at least)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.