[Webkit-unassigned] [Bug 100258] BlackBerry fix for webgl-depth-texture.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100258





--- Comment #4 from Jonathan Feldstein <jfeldstein at rim.com>  2012-10-24 12:10:54 PST ---
(In reply to comment #3)
> (From update of attachment 170428 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170428&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +
> > +        No new tests (OOPS!).
> > +
> 
> Please change this line with some short explanation. Patch with (OOPS!) in changelog cannot get committed
> 
> > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:-121
> > -#if !PLATFORM(BLACKBERRY)
> >      case GraphicsContext3D::UNSIGNED_INT_24_8:
> > -#endif
> 
> any idea about why we did this before?

I spoke with a few other people and no one came up with a good reason. Worst case instead of returning false we'd eventually cause a gl error for an invalid enum. Not that that should happen anyways.

I'll add you as the reviewer at the same time as removing the no new tests line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.