[Webkit-unassigned] [Bug 99578] [EFL] Share WebKit-Gtk's Accessibility implementation with others WebKit ports.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99578


Grzegorz Czajkowski <g.czajkowski at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |g.czajkowski at samsung.com




--- Comment #6 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2012-10-24 01:26:36 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > [...]
> > Hmm, good point. The problematic point would be the usage of gail_text_util 
> > methods on the AtkText implementation. FWIW, GTK and clutter are not using 
> > them anymore, but using a private fully pango-based library.
> 
> Yes, which reminds me of another issue with the a11y code here: pango is still being used in some places there and, as far as I know, its usage inside WebKit is discouraged and should be avoided.
> 
> I think the right replacement is TextBreakIterator, not 100% sure, though.

Pango has been finally removed from WebKit-EFL dependencies. We found out all needed replacements for example, the spell checker feature uses TextBreakIterator to determine the beginning/end of the word (bug 94320).

> 
> > So another task would be check what EFL is using for the text rendering.
> 
> Text rendering code is not an issue in WebCore/accessibility/gtk. Pango is being used only to get a PangoLayout to pass to gail_text_util_get_text() so I think getting rid of gail would be enough (as easy as it sounds, as hard as it might be :-))

I completely agree with you. IMHO it looks like  WebCore methods could be used (like TextIterator) instead of gail_text_util_get_text(). The current implementation already uses it and based on Range (WebCore/dom/Range.h) we could manipulate TextIterator object in the same way as gail is doing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.