[Webkit-unassigned] [Bug 99660] toggle FPS counter option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99660





--- Comment #20 from egraether at chromium.org  2012-10-23 15:50:14 PST ---
(In reply to comment #16)
> (From update of attachment 169736 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169736&action=review
> 
> > Source/WebCore/inspector/InspectorPageAgent.cpp:724
> > +    m_state->setBoolean(PageAgentState::showFPSCounter, show);
> 
> should we restore this value in InspectorPageAgent::restore() ?

I removed this line again. It was there because I copied the implementation of the 'showPaintRects' setting. I could not track down in which cases InspectorPageAgent::restore() is called. Is there a reason to save and restore 'showFPSCounter'?

> > Source/WebKit/chromium/src/WebViewImpl.cpp:854
> > +#endif
> 
> #else
>     UNUSED_PARAM(show);

This change was not necessary. This condition now contains only the call to 'loadFontAtlas()', because this method was declared under the same condition in WebViewImpl.h

thank you

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.