[Webkit-unassigned] [Bug 100132] New: negative scale values in -webkit-image-set are handled incorrectly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 23 08:56:36 PDT 2012


           Summary: negative scale values in -webkit-image-set are handled
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rbyers at chromium.org
                CC: bdakin at apple.com

I noticed none of the existing image-set-parsing tests checked negative scale values, eg:
background-image: url(a.png) -2x, url(b.png) -1x

I tried this in chromium and it appears like it's simply ignorning the leading negative sign.  I.e., the '-2x' image is used when the device scale factor is 2.  The cssText property also shows the absolute value without the sign.

I'm assuming such rules should be invalid.  I glanced at the code for this, and it looks like CSSParser::parseImageSet is supposed to fail on negative values:
        if (imageScaleFactor <= 0)
            return 0;

So parseDouble is presumably ignorning a leading '-'.  I haven't dug in further.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list