[Webkit-unassigned] [Bug 99660] toggle FPS counter option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99660





--- Comment #18 from Dana Jansens <danakj at chromium.org>  2012-10-23 08:19:57 PST ---
(From update of attachment 169736)
View in context: https://bugs.webkit.org/attachment.cgi?id=169736&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:839
> +bool WebViewImpl::getShowFPSCounter()

name this "showFPSCounter()"

> Source/WebKit/chromium/src/WebViewImpl.cpp:846
> +#if USE(ACCELERATED_COMPOSITING)

chromium code always has ACCELERATED_COMPOSITING enabled, so this is not needed here.

> Source/WebKit/chromium/src/WebViewImpl.cpp:852
> +        m_layerTreeView->setShowFPSCounter(show);
> +        if (show)
> +            loadFontAtlas();

Can we loadFontAtlas() first so we can DCHECK that the atlas exists when turning on the FPS counter?

> Source/WebKit/chromium/src/WebViewImpl.cpp:3953
> +            if (settingsImpl()->showFPSCounter())
> +                setShowFPSCounter(true);

Why is this here? If settingsImpl()->showFPSCounter() is true, doesn't that mean that setShowFPSCounter(true) was already called (since it is calling settingsImpl()->setShowFPSCounter(show))?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.