[Webkit-unassigned] [Bug 100102] New: [WK2] [GTK] TestWebKitAccessibility is not being run

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100102

           Summary: [WK2] [GTK] TestWebKitAccessibility is not being run
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mario at webkit.org


It seems a line got in run-gtk-tests by mistake along with SVN r120944, causing this test not to be run in WK2 bots:

     def _start_accessibility_daemons(self):
         return False
         spi_bus_launcher_path = self._lookup_atspi2_binary('at-spi-bus-launcher')
         spi_registryd_path = self._lookup_atspi2_binary('at-spi2-registryd')
         [...]

Additionally, there seems to be a mistake in configure.ac as well, since the following block is now _after_ the definition of enable_webkit2, meaning that the PKG_CHECK_MODULES is never executed:

  # check if atspi2 is available (only needed for Webkit2 unit tests)
  if test "$enable_webkit2" = "yes"; then
     PKG_CHECK_MODULES([ATSPI2],
                       [atspi-2 >= $ATSPI2_REQUIRED_VERSION],
                       [have_atspi2=yes], [have_atspi2=no])

     AC_SUBST([ATSPI2_CFLAGS])
     AC_SUBST([ATSPI2_LIBS])
  fi

This needs to be fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.