[Webkit-unassigned] [Bug 99578] [EFL] Share WebKit-Gtk's Accessibility implementation with others WebKit ports.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99578





--- Comment #4 from Alejandro Piñeiro <apinheiro at igalia.com>  2012-10-23 03:43:30 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > [...]
> > Anyway, I think that the first step could check if there are some kind of any
> > "pure gtk" code on current accessibility/gtk directory. If so, next step would
> > be split that code, and check if we need to maintain a accessibility/gtk
> > directory with that gtk-specific code, or move it to the general gtk code
> 
> As far as I know, there are a couple of references to GtkWidget in WebKitAccessibleWrapperAtk.cpp and then some usages of GAIL's gail_text_util_get_text() in WebKitAccessibilityInterfaceText.cpp. Other than that, the remaining stuff should be reusable among ports, I think.

Hmm, good point. The problematic point would be the usage of gail_text_util methods on the AtkText implementation. FWIW, GTK and clutter are not using them anymore, but using a private fully pango-based library. So another task would be check what EFL is using for the text rendering.

Probably this bug will became a metabug of all the tasks needed to make the move. Your paragraph detects two.

> > (as I'm thinking on gtk-widget initialization related code)
> 
> Not sure what you mean. If you're talking about the initialization of the WebView (which is a GtkWidget) and its implementation of gtk_widget_get_accessible(), such code is not here in WebCore/accessibility/gtk, but in WebKit/gtk/webkit (for WK1) and WebKit2/UIProcess/API/gtk (for WK2).

Yes I was talking about that. So good to know that we can discard my concern as a new task.


> Btw, forgot to mention it before, but I also agree with sharing this a11y code between the GTK and the EFL ports looks like a good idea

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.