[Webkit-unassigned] [Bug 99660] toggle FPS counter option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99660





--- Comment #17 from Andrey Kosyakov <caseq at chromium.org>  2012-10-22 01:48:28 PST ---
(From update of attachment 169736)
View in context: https://bugs.webkit.org/attachment.cgi?id=169736&action=review

> Source/WebCore/inspector/front-end/Settings.js:61
> +    isAcceleratedCompositingActive: false

is that a setting?

> Source/WebCore/inspector/front-end/inspector.js:370
> +    PageAgent.isAcceleratedCompositingActive(WebInspector._initializeCapability.bind(WebInspector, "isAcceleratedCompositingActive", null));

I don't think it's appropriate use for capabilities -- a capability is seen a constant property of particular combination of embedder, platform and enviroment, not something that may vary from page to page or even within a page lifetime. You probably want to check the platform supports accelerated compositing and can display FPS overlay.

> Source/WebCore/inspector/front-end/inspector.js:481
> +    else if (Capabilities.showFPSCounter)
> +        WebInspector.settings.showFPSCounter.set(true);

Could you explain the intent behind these lines?

> Source/WebKit/chromium/src/InspectorClientImpl.cpp:200
> +bool InspectorClientImpl::isAcceleratedCompositingActive()
> +{
> +    return m_inspectedWebView->isAcceleratedCompositingActive(); 
> +}

So we know whether the accelerated compositing is active at some point in time. What if it changes later?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.