[Webkit-unassigned] [Bug 99850] [EFL][WK2] Use the port independent PageViewportController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99850





--- Comment #5 from Yael <yael.aharon.m at gmail.com>  2012-10-21 05:14:10 PST ---
(In reply to comment #3)
Thanks for your review :)
> (From update of attachment 169748 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169748&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.messages.in:76
> > +#if PLATFORM(QT) || PLATFORM(EFL) && USE(COORDINATED_GRAPHICS)
> 
> Maybe we should have a different define?
> 
We already have so many flags, I would hate to introduce a new one.
I think USE(COORDINATED_GRAPHICS) is turned on by default in Qt port, so I will try to keep only that and see if something breaks.

> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:281
> > +static Evas_Coord_Point adjustedPointForScaling(Evas_Coord_Point point, Ewk_View_Private_Data* priv)
> 
> Can't we follow Qt naming?
> 
> QPointF QQuickWebView::mapToWebContent(const QPointF& pointInViewCoordinates) const
> QRectF QQuickWebView::mapRectToWebContent(const QRectF& rectInViewCoordinates) const
> 
ok

> Also I would add priv before point as it is a hard requirement
ok

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.