[Webkit-unassigned] [Bug 99706] MIPS LLInt implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99706





--- Comment #16 from Filip Pizlo <fpizlo at apple.com>  2012-10-20 13:09:37 PST ---
(In reply to comment #15)
> (In reply to comment #13)
> > (In reply to comment #11)
> > > (From update of attachment 169392 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=169392&action=review
> > > 
> > > > Source/JavaScriptCore/offlineasm/mips.rb:190
> > > > +def mipsLowerBranchOps(list)
> > > 
> > > Did you copy and paste all of this code?
> > > 
> > > You should make an effort to reuse code rather than copy and pasting it.
> > 
> > What you mean? I started from a copy of the armv7 implementation and I can't see how could there be more code reusing. Could you give me more details?
> 
> I've created a bug for this: https://bugs.webkit.org/show_bug.cgi?id=99745
> 
> I have a pretty good idea of how I'd like this to work, so that the code is more maintainable in the future.  I'll try to hack something up.

This is landed in http://trac.webkit.org/changeset/131989

Do you guys think you can redo the MIPS backend around the common things in risc.rb?

Feel free to refactor risc.rb further if you need to.  Remember, this code isn't performance-critical so you can have as many little phases as is convenient.  The only requirements are (a) correctness (obviously) and (b) generating decent code in the end.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.