[Webkit-unassigned] [Bug 98990] [Texmap][CSS Shaders] Enable CSS Shaders in TextureMapperGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98990





--- Comment #5 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-10-20 08:26:29 PST ---
(From update of attachment 169766)
View in context: https://bugs.webkit.org/attachment.cgi?id=169766&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:72
> +class TextureMapperCustomFilterRendererMapHolder {
> +#if ENABLE(CSS_SHADERS)
> +public:
> +    typedef HashMap<const CustomFilterOperation*, RefPtr<CustomFilterRenderer> > CustomFilterRendererMap;
> +    virtual CustomFilterRendererMap* customFilterRendererMap() = 0;
> +    virtual void setCustomFilterGlobalContext(PassOwnPtr<CustomFilterGlobalContext>) = 0;
> +    virtual CustomFilterGlobalContext* customFilterGlobalContext() = 0;
> +#endif

Why not have the renderer map as a member of TextureMapper, instead of virtualizing the holder?
The patch would be a lot shorter and succinct if you did that...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.