[Webkit-unassigned] [Bug 99836] [GTK] Add API to get the WebKitWebView associated to a WebKitDownload to WebKit2 GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99836





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-20 01:37:14 PST ---
(In reply to comment #3)
> (From update of attachment 169614 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169614&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2780
> > +WebKitDownload* webkit_web_view_download_uri(WebKitWebView* webView, const char* uri)
> 
> Why is it useful to start a download with with a WebView?

To use the web view as the initiating page of the download. This allow you to show the downloasd in the right window, for example in the application. Imagine you are implementing your own custom context menu, for example, you want to start the download associated to the web view that showed the context menu. Note that WebContext::download() takes a initiating web page as first argument, but we are always passing NULL in this moment. We could have webkit_web_context_download_uri_for_web_view() to pass an initiating page to download() but I think it's more natural to have the method in the web view instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.