[Webkit-unassigned] [Bug 99852] Gstreamer 1.0 not working

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99852





--- Comment #3 from Philippe Normand <pnormand at igalia.com>  2012-10-19 10:42:15 PST ---
(From update of attachment 169644)
View in context: https://bugs.webkit.org/attachment.cgi?id=169644&action=review

>> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:-91
>> -    ASSERT(!ptr || !gstObjectIsFloating(GST_OBJECT(ptr)));
> 
> You should not get rid of the entire assert no? Testing pointer nullity is still valid to me.

+1

> Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:-46
> -    GstCaps* caps = gst_pad_get_current_caps(pad);
> -    if (!caps)
> -        caps = gst_pad_query_caps(pad, 0);
> -    return adoptGRef(caps); // gst_pad_query_caps and gst_pad_get_current_caps return a new reference.

gst_pad_get_current_caps() can return NULL AFAIK. What should we do in that case instead of querying the caps to the pad?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.