[Webkit-unassigned] [Bug 99816] [EFL] Fix failure to access the inspector resources

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 19 02:38:10 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99816





--- Comment #3 from Thiago Marcos P. Santos <tmpsantos at gmail.com>  2012-10-19 02:39:05 PST ---
(From update of attachment 169567)
View in context: https://bugs.webkit.org/attachment.cgi?id=169567&action=review

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:147
> -    String inspectorFilesPath = "file://" + String(WEB_INSPECTOR_INSTALL_DIR);
> +    String inspectorFilesPath = ASCIILiteral(WEB_INSPECTOR_INSTALL_DIR);
>      if (access(inspectorFilesPath.utf8().data(), R_OK))
> -        inspectorFilesPath = "file://" + String(WEB_INSPECTOR_DIR);
> +        inspectorFilesPath = ASCIILiteral(WEB_INSPECTOR_DIR);
>  
> -    return inspectorFilesPath;
> +    return "file://" + inspectorFilesPath;

I don't think it is safe to assume ASCII on the install path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list