[Webkit-unassigned] [Bug 91844] [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844


Laszlo Gombos <laszlo.gombos at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laszlo.gombos at webkit.org




--- Comment #69 from Laszlo Gombos <laszlo.gombos at webkit.org>  2012-10-18 17:10:42 PST ---
> But in webkit2 it is more confusing, e.g. createPlugin function in WebPage.cpp:
> #if ENABLE(PLUGIN_PROCESS)
>     return PluginProxy::create(pluginPath);
> #elif ENABLE(NETSCAPE_PLUGIN_API)
>     NetscapePlugin::setSetExceptionFunction(NPRuntimeObjectMap::setGlobalException);

AFAIK the distinction is that there could be different kinds of plugins - and Netscape plugins would be one of the kind of plugins. Perhaps the build flag for build-webkit should be called "no-plugins", but the build flags in the source files seems to be properly named.

> I'm wondering if plugin process should be created at all when NETSCAPE_PLUGIN_API is off. 

For EFL and (and probably GTK) ports I would agree.

> I think it will be good to make new bug on bugzilla for this combination of macros.

See bug 99757.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.