[Webkit-unassigned] [Bug 63257] When blocking localStorage, Firefox throws a security exception on access, and maybe so should we

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63257





--- Comment #34 from Dan Carney <dcarney at google.com>  2012-10-18 16:14:07 PST ---
(In reply to comment #32)
> (From update of attachment 169176 [details])
> I mentioned this on another patch, but I might as well mention it here as well.  The UNLIKELY doesn't really do anything.  We should use it only when we have direct evidence that it actually improves performance.  Otherwise it just becomes copy pasta.

Yeah I've been trying to avoid it in generally, it's just that this patch started out trying to additionally fix a performance problem from another bug, so they were there a long time ago.  I'll get rid of them, as I'm assuming the access cache benefit is the big win and actually performing db operations will take way longer than checking a few fields.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.