[Webkit-unassigned] [Bug 99706] MIPS LLInt implementation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 12:05:48 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99706





--- Comment #15 from Filip Pizlo <fpizlo at apple.com>  2012-10-18 12:06:43 PST ---
(In reply to comment #13)
> (In reply to comment #11)
> > (From update of attachment 169392 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=169392&action=review
> > 
> > > Source/JavaScriptCore/offlineasm/mips.rb:190
> > > +def mipsLowerBranchOps(list)
> > 
> > Did you copy and paste all of this code?
> > 
> > You should make an effort to reuse code rather than copy and pasting it.
> 
> What you mean? I started from a copy of the armv7 implementation and I can't see how could there be more code reusing. Could you give me more details?

I've created a bug for this: https://bugs.webkit.org/show_bug.cgi?id=99745

I have a pretty good idea of how I'd like this to work, so that the code is more maintainable in the future.  I'll try to hack something up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list