[Webkit-unassigned] [Bug 99655] New: V8::AdjustAmountOfExternalAllocatedMemory calls in WebCoreStringResource are inaccurate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99655

           Summary: V8::AdjustAmountOfExternalAllocatedMemory calls in
                    WebCoreStringResource are inaccurate
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org, haraken at chromium.org


V8::AdjustAmountOfExternalAllocatedMemory calls in WebCoreStringResource are inaccurate

The v8 API (according to api.cpp):
intptr_t V8::AdjustAmountOfExternalAllocatedMemory(intptr_t change_in_bytes) {

We're calling this function, assuming that AtomicString/String are take up 2 bytes per character:
                v8::V8::AdjustAmountOfExternalAllocatedMemory(2 * m_atomicString.length());

Which is wrong... In many ways.  Especially in the context of 8-bit strings, or even just the fact that strings are shared?

But I'm not sure how much the accuracy of this reporting matters (if at all).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.