[Webkit-unassigned] [Bug 98989] [CSS Shaders] Add CustomFilterRenderer to reuse this class by Accelerated Compositing.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98989





--- Comment #6 from Huang Dongsung <luxtella at company100.net>  2012-10-17 15:55:21 PST ---
(In reply to comment #5)
> > I know you just copy-pasted this one, but it seems like NO_INPUT_TEXTURE is never used. Can you please remove CustomFilterDrawType type? I think it was intended to help implementing a renderer that has the input already as a texture instead of just some bytes in the memory.
> I don't understand why only mix(<uri> ..) needs the DOM element texture. I think just <uri> fragmentShader also needs the DOM element texture.
> http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#fragmentShader-attribute
> 
> Could I remove CustomFilterProgramType also?

I understand my old question is wrong after reading spec: "38.2.1. Fragment Shaders Differences with GLSL." http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#fragment-shaders-differences-with-glsl

I understand <uri> fragmentShader can not use the DOM element texture.  <uri> fragmentShader can just render a simple shader like "gl_FragColor = vec4(1.0, 0.0, 0.0, 1.0);". Am I right?

As you mentioned, we just need to remove CustomFilterDrawType. I'll do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.