[Webkit-unassigned] [Bug 11645] Table with percentage column widths doesn't scale to fill the entire width of a table containing it

Wed Oct 17 03:31:08 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=11645


--- Comment #20 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-10-17 03:31:58 PST ---
(In reply to comment #18)
> (From update of attachment 167479 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167479&action=review
> 
Thanks Julien for the review.

> > LayoutTests/fast/table/scale-nested-percent-width-cols.html:1
> > +<!DOCTYPE html>
> 
> FWIW, this could have used check-layout.js (http://lists.webkit.org/pipermail/webkit-dev/2012-October/022490.html). The upside would be to remove the ref-test that ends up being super close to the test case.
> 
> Note that the ref-test approach works OK in this case too.
> 
I wasn't aware of check-layout.js until now. Shall further study its usage for future use.

> > LayoutTests/fast/table/scale-nested-percent-width-cols.html:6
> > +<p>No red background color should be visible for the following two tables.</p>
> 
> For the record, you *do* see some red which makes this sentence confusing for anyone not familiar with tables.
> 
> > LayoutTests/fast/table/scale-nested-percent-width-cols.html:10
> > +            <table style="width: 100%; background-color: red;">
> 
> Add: style="...; border-spacing: 0px;" to your list...
> 
> > LayoutTests/fast/table/scale-nested-percent-width-cols.html:12
> > +                    <td>
> 
> ... and add style="padding: 0px" here too and no red should be shown.
> 
I understand, since red was still visible the statement would have been misleading. Have made the necessary changes as suggested by you.

> > LayoutTests/fast/table/scale-nested-percent-width-cols.html:13
> > +                        <table style="background-color: green;">
> 
> I would support moving this common style into a class shared by the 2 examples.
> 
Done.

> > LayoutTests/platform/chromium/TestExpectations:3758
> > +# Requires rebaselining after https://bugs.webkit.org/show_bug.cgi?id=11645
> > +webkit.org/b/11645 fast/table/025.html [ Failure ]
> 
> You are right to add that.
> 
> A couple of comments:
> * What happened to gtk, win and efl?
> * For Chromium, you really have the choice. Disabling it and doing the rebaselining yourself with webkit-patch rebaseline-server (or rebaseline-expectations) or just omitting so that the gardener picks the new baselines when the patch land.
Have added the existing failing test in the TextExpectation files for the remaining ports as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.