[Webkit-unassigned] [Bug 98856] Add moveDoubleToInts and moveIntsToDouble to MacroAssemblerMIPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98856





--- Comment #30 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-10-16 02:37:23 PST ---
(In reply to comment #29)
> (In reply to comment #28)
> > (In reply to comment #27)
> > > (In reply to comment #26)
> > > > (In reply to comment #25)
> > > > > (From update of attachment 168894 [details] [details] [details] [details] [details])
> > > > > void mfhc1(RegisterID rt, FPRegisterID fs) removed, thanks to Peter Gal.
> > > > 
> > > > Just curious: should we use it in the vmov? or the #ifdef guards were wrong? or something else?
> > > Using vmov hides it from higher level (if we want #ifdefs later). With or without mfhc1 the operation will be implemented with two instructions so it seems no performance gain from mfhc1 just looks better then the R1 solution. If there is any reason for using it then I will add it to vmov.
> > 
> > Okay. BTW: why did you removed the r? flag?
> Mistake. If I choose + from the r list without name then Oliver or previous reviewer remains? I will try. I have to resend this patch so many times.

Well.... if you can only set the r? flag. and a reviewer fill set it to r+. additional set the cq? flag so when a reviewer sets it to cq+ it'll be committed in time automatically. Also you don't need to re-upload it so many times, if you have want to edit the flags. (only if you wan to run the ews you should reupload, but in this case it is irrelevant)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.