[Webkit-unassigned] [Bug 99382] New: Fold setCellLogicalWidths logic into RenderTableSection layout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 16:17:01 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99382

           Summary: Fold setCellLogicalWidths logic into
                    RenderTableSection layout
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tables
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jchaffraix at webkit.org
                CC: hyatt at apple.com, bdakin at apple.com, robert at webkit.org,
                    inferno at chromium.org


RenderTable's and RenderTableSection's setCellLogicalWidths propagate the table layout's logical widths to the cells. This is done as a pre-step to doing RenderTableSection::layout as it may dirty the sections.

Our implementation is artificial and adds an extra unneeded cells' walking: if any column's logical width change, we have to relayout all our sections anyway. As we lay our sections / rows, we can mark the cells as we go.

Following the previous paradigm as several advantages:
* avoids calling setNeedsLayout(true, MarkContainingBlockChain) which is a programming error.
* removes the clunky cell's repainting code.
* avoids a cells' walking.
* removes the artificial split between this "phase" and the regular layout.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list