[Webkit-unassigned] [Bug 98856] Add moveDoubleToInts and moveIntsToDouble to MacroAssemblerMIPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98856





--- Comment #17 from Oliver Hunt <oliver at apple.com>  2012-10-15 10:24:20 PST ---
(In reply to comment #16)
> (In reply to comment #15)
> > (From update of attachment 168436 [details] [details])
> > Please remove the unrelated style changes from the functionality changes.
> Those style changes was necessary to pass style checking (otherwise style checking said: Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2018:  Weird number of spaces at line-start.) So I could have style-fixed only new functions but I wanted to make it consistent. Wouldn't it be reviewed/accepted this way?

We don't make large (and unrelated) formatting/style changes at the same time as making a functionality change.  The formatting changes obscure the actual content of the fix.

You can do the formatting fix before or after, but not during the functionality fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.