[Webkit-unassigned] [Bug 99149] [EFL][WTR] Perform blur before focus on each test in WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99149





--- Comment #14 from Mariusz Grzegorczyk <mariusz.g at samsung.com>  2012-10-15 06:53:45 PST ---
(In reply to comment #12)
> (From update of attachment 168374 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168374&action=review
> 
> You should unskip the flaky tests that it fixes in the same patch otherwise we cannot tell that it changes anything.

In editing category there's a lot of skipped subcategories(deleting, inserting, selection, spelling, style). A lot have also missing expected results. Some of them have different cause of being skipped.

To check this change you can run following 2 tests one after other:
editing/undo/undo-iframe-location-change.html
LayoutTests/editing/undo/undo-indent.html
Without this patch you can see following lines in diff file: 
-EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of OL > DIV > BODY > HTML > #document to 9 of OL > DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification

I suggest make gardening in separate patch including this change.

> 
> > Tools/WebKitTestRunner/TestController.cpp:518
> > +    m_mainWebView->blur();
> 
> We - at least - need a comment here to explain why the EFL port needs this.

In DRT following code at the beginning of each test solves this problem: ewk_frame_feed_focus_in(mainFrame());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.