[Webkit-unassigned] [Bug 99315] [GTK] Add API to set a WebKitWebView in view source mode to WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 06:46:22 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99315





--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2012-10-15 06:47:11 PST ---
(From update of attachment 168696)
View in context: https://bugs.webkit.org/attachment.cgi?id=168696&action=review

> Source/WebKit2/UIProcess/WebFrameProxy.h:111
> +    bool inViewSourceMode() const { return m_inViewSourceMode; }

What about implementing this method through a (new) message to the Web process that would end up calling coreFrame->inViewSourceMode() to get the actual state of the web view from the value of WebCore::Frame's m_inViewSourceMode?

I know it's probably too much stuff for just keeping track of this property and that doing that in the UI process will probably be good enough, but that might change if in the future we decide to call WebCore::Frame::setInViewSourceMode() from somewhere else in WebCore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list