[Webkit-unassigned] [Bug 98733] [WK2] Add CustomFilterOperation serialization in ArgumentCoder.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98733


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168595|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #21 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-10-14 18:48:18 PST ---
(From update of attachment 168595)
View in context: https://bugs.webkit.org/attachment.cgi?id=168595&action=review

Great!
Please fix nit-picks before committing...

> Source/WebKit2/ChangeLog:10
> +        Coordinated Graphics will use this css shaders serialization when it enables CSS
> +        Shaders.

Please remove these lines.

> Source/WebKit2/ChangeLog:30
> +            WebCustomFilterProgram is made from serialized data of
> +            StyleCustomFilterProgram in UI Process. UI Process uses this class
> +            instead of StyleCustomFilterProgram because UI Process can not get a
> +            custom filter program via network.

Just say "WebCustomFilterProgram is made to serialize the data of a StyleCustomFilterProgram to the UI process."

> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:29
> +#if USE(COORDINATED_GRAPHICS)

Put this line after the main include

> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:150
> +                encoder->encode(parameters[i]->name());
> +                encoder->encodeEnum(parameters[i]->parameterType());

Please save parameters[i] in a local variable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.