[Webkit-unassigned] [Bug 99154] Refactor MacroAssembler interfaces to differentiate the pointer operands from the 64-bit integer operands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99154





--- Comment #4 from Gavin Barraclough <barraclough at apple.com>  2012-10-12 17:49:54 PST ---
Hey Yuqiang,

This all looks good in principal – but:

(1) Please put up just a patch with MacroAssembler changes alone.  We should be able to refactor the MacroAssembler to support Imm64 & more *64* operations separately, and then land changes to the JIT to use it.  The runtime changes necessary for x32 should be separate again.

(2) The X86_64 MacroAssembler changes duplicate a lot of functionality, in copying & pasting many operations into Ptr & 64 variants.  E.g. xor64, xorPtr.  Instead I think we should try to constrain the concept of Ptr sized operations to the MacroAssembler, so on X86_64 <foo>Ptr should be remapped to <foo>64, as we currently map <foo>Ptr to <foo>32 on other platforms.  Going forwards we don't want to be copying & pasting all 64-bit operations to both Ptr & 64 variants in the X86_64 macro assembler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.