[Webkit-unassigned] [Bug 89666] Separate WebKit2 instances use the same local storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89666


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167530|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #35 from Simon Hausmann <hausmann at webkit.org>  2012-10-12 03:27:08 PST ---
(From update of attachment 167530)
View in context: https://bugs.webkit.org/attachment.cgi?id=167530&action=review

I think the patch looks good. The only two issues I can find are the missing notImplemented() and the static_cast that appears to be unnecessary. Please fix those before landing :)

(And I suppose this needs very careful perhaps manual landing, since it affects the quite a few ports)

> Source/WebKit2/UIProcess/win/WebContextWin.cpp:107
> +    // FIXME: not implemented!

Use notImplemented(); here?

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:271
> -        RetainPtr<NSURLCache> parentProcessURLCache(AdoptNS, [[NSURLCache alloc] initWithMemoryCapacity:cacheMemoryCapacity diskCapacity:cacheDiskCapacity diskPath:parameters.nsURLCachePath]);
> +        RetainPtr<NSURLCache> parentProcessURLCache(AdoptNS, [[NSURLCache alloc] initWithMemoryCapacity:cacheMemoryCapacity diskCapacity:cacheDiskCapacity diskPath:static_cast<NSString*>(parameters.diskCacheDirectory)]);

Why is the static_cast needed here?

It seems that with

    diskPath:parameters.nsURLCachePath

the nsURLCachePath as a String. With 

    diskPath:static_cast<NSString*>(parameters.diskCacheDirectory)

the diskCacheDirectory appears to be a String, too. So I don't understand why the cast is needed :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.