[Webkit-unassigned] [Bug 88606] [Shadow DOM] Needs @host rule for ShadowDOM styling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88606


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168155|review?                     |review-
               Flag|                            |




--- Comment #35 from Hajime Morrita <morrita at google.com>  2012-10-12 00:38:24 PST ---
(From update of attachment 168155)
View in context: https://bugs.webkit.org/attachment.cgi?id=168155&action=review

> Source/WebCore/css/RuleSet.h:50
> +    RuleData(StyleRule*, unsigned selectorIndex, unsigned position, unsigned addRuleState);

Coud you use AddRuleState instead of unsigned?

> Source/WebCore/css/StyleResolver.cpp:438
> +void StyleResolver::addHostRule(StyleRuleHost* hostRule, bool hasDocumentSecurityOrigin, const ContainerNode* scope)

Can we move this implementation more to StyleScopeResolver?
Ideally all @host related code should be owned by StyleScopeResolver.
I know it's unfeasible for now. But I think we could be better here.

> Source/WebCore/css/StyleResolver.cpp:440
> +#if ENABLE(STYLE_SCOPED)

This isn't related STYLE_SCOPED. This should be part of SHAODW_ROOT.

> Source/WebCore/css/StyleResolver.cpp:781
> +#if ENABLE(STYLE_SCOPED)

Ditto.

> Source/WebCore/css/StyleResolver.cpp:790
> +#if ENABLE(STYLE_SCOPED)

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.