[Webkit-unassigned] [Bug 97646] [EFL][WK2] WebProcess keeps on waiting for UIProcess

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97646





--- Comment #10 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-10-11 21:56:54 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Don't you need to set setRendererActive(false) in ewk_view_accelerated_compositing_mode_exit() ?
> 
> What is the benefit of doing that?
> We need to call setActive(true) to trigger the first renderNextFrame, so that we can start rendering.

First, I'm not expert for graphics area. To my experience, however, we have been set true/false in a pair of functions generally if there is needs to set specific setting. In this case, ewk_view_accelerated_compositing_mode_exit() might don't need to set setActive(false) because ewk_view_accelerated_compositing_mode_exit() will be called only once when existing program, right ?  If so, we might not call setActive(false) from a functionality perspective. But, IMO, it is not bad to call setActive(false) in _exit() from a pair of functions perspective. If the _exit() will be called many times, isn't it better or safer to call setActive(false) in _exit() ?

Anyway, patch was already landed. I'm just wondering about this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.