[Webkit-unassigned] [Bug 98344] [EFL] Add the file system path set/get APIs.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 21:51:52 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=98344





--- Comment #10 from Dongwoo Joshua Im (dwim) <dw.im at samsung.com>  2012-10-11 21:52:33 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> >
> > By app, I mean the browser for example.
> > 
> > What's the point of adding a public API (ewk_settings_file_system_path_set) if the browser can NOT call it? IMO, it should be private and called only once in ewk_main.
> > 
> > Right now, you add a public function that will hit an assertion if the browser calls it :( I don't see the point.
> 
> Hum..
> I understand what you are saying...
> 
> So, setter is still needed, but it shouldn't be in public.
> And, I think getter also not needed to be in public.
> 
> Then, I will make setter/getter as a private function.

And then, no unit test is needed, IMO.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list