[Webkit-unassigned] [Bug 98639] [EFL][WK2] Add support for Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98639





--- Comment #18 from Seokju Kwon <seokju.kwon at samsung.com>  2012-10-11 16:50:38 PST ---
(In reply to comment #17)
> (From update of attachment 168298 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168298&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1975
> > +Eina_Bool ewk_view_inspector_show(Evas_Object* ewkView)
> 
> Why can't I show it for an element? Most browsers support this. Did you check the api of other ports? like the Qt webkit1 api, that one at least suports this
> 
> Being able to inspect an element directly when showing the inspector is a really nice feature
> 

What kind of api on other ports? I think we can inspect an element when showing the inspector. But attaching the window does not support yet.

> > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:96
> > +    Ewk_Settings* settings = ewk_view_settings_get(m_inspectorView);
> > +    ewk_settings_file_access_from_file_urls_allowed_set(settings, true);
> 
> can't this be dangerous? comment?
> 

We should access the inspector.html on inspector view. 

> > Tools/MiniBrowser/efl/main.c:150
> > +    } else if (!strcmp(ev->key, "i") && ctrlPressed) {
> > +        info("Show Inspector (Ctrl+i) was pressed.\n");
> > +        ewk_view_inspector_show(obj);
> 
> Can't we add a context menu instead? the launcher could really need this!

Right. But we will use it until adding a context menu temporarily.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.