[Webkit-unassigned] [Bug 98913] Change transformation precision from double to float
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 11 10:10:16 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=98913
--- Comment #6 from WebKit Review Bot <webkit.review.bot at gmail.com> 2012-10-11 10:10:55 PST ---
Attachment 168180 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/wtf/Platform.h', u'Source/WebCo..." exit_code: 1
Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp:36: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/AffineTransform.h:64: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/graphics/transforms/AffineTransform.h:64: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/graphics/transforms/AffineTransform.h:64: The parameter name "e" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/graphics/transforms/AffineTransform.h:64: The parameter name "f" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/graphics/transforms/AffineTransform.h:70: The parameter name "a" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/graphics/transforms/AffineTransform.h:70: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/graphics/transforms/AffineTransform.h:70: The parameter name "e" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/graphics/transforms/AffineTransform.h:70: The parameter name "f" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:76: SMALL_NUMBER is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:266: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4]
Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:253: The parameter name "p" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 19 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list