[Webkit-unassigned] [Bug 99019] [GTK] REGRESSION(r131033): Favicons don't work in MiniBrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 08:43:17 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99019


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168228|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-11 08:43:58 PST ---
(From update of attachment 168228)
View in context: https://bugs.webkit.org/attachment.cgi?id=168228&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:524
> +    // Enable the favicon database, by specifying the default directory.
> +    webkit_web_context_set_favicon_database_directory(webkit_web_view_get_context(window->webView), NULL);
> +

We don't want to do this for every window, since we are sharing the web process, if would be better to do it only once in main.c before browser windows are created.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list